Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing await in vite builder #20409

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix missing await in vite builder #20409

merged 1 commit into from
Jan 3, 2023

Conversation

joshwooding
Copy link
Member

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@joshwooding joshwooding requested a review from IanVS December 25, 2022 02:21
@IanVS
Copy link
Member

IanVS commented Dec 25, 2022

Is this causing problems? I thought that Vite would handle this for us.

@joshwooding
Copy link
Member Author

Is this causing problems? I thought that Vite would handle this for us.

It’s not causing any errors but I get a warning in my IDE. Happy to close the PR?

IanVS
IanVS approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well, for consistency. Though I wonder if there's any perf difference between awaiting them here and letting Vite handle them.

@joshwooding joshwooding merged commit 7f72560 into next Jan 3, 2023
@joshwooding joshwooding deleted the fix-missing-await-in-vite-config branch January 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

Assignees
No one assigned
Labels
bug builder-vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @IanVS